Fixed deprecated deprecations (fixes #419)

[althaus]

No description provided.

[bocharsky-bw]

Hey @althaus !

Thank you for this PR and sorry for late review... I left a few comments, could you take a look at them? And looks like tests are not green here, I wonder if it's related to these changes

[althaus]

PHPStan complains about changes in the Symfony bundles which looks like bad dependencies.

Travis could be related. I'll check the tests.

[bocharsky-bw]

Travis could be related. I'll check the tests.

Thank you! Let me know if it's related. If it's not - we still can merge it I think but would be cool to fix it anyway, probably in a separate PR

[althaus]

Travis could be related. I'll check the tests.

Thank you! Let me know if it's related. If it's not - we still can merge it I think but would be cool to fix it anyway, probably in a separate PR

After checking Travis I came up with a show stopper. Travis complains as the new deprecation syntax requires Symfony 5. The prior versions 3 and 4 only support the simple string. I have no clue how to solve this, if you don't want to release a version of this bundle which drops support for those earlier versions. :(

[bocharsky-bw]

Ah, I see... that's a bummer :/ Thank you for researching on it! Yeah, we do want to support those versions too, so I think we can't merge this as is for now, unfortunately. If anyone knows how to work around this in a reasonable way and avoid BC breaks - let's discuss, otherwise, we need to wait until we drop Symfony 3 and 4 versions support to merge this

[rogamoore]

Related to this I found symfony/symfony#37284 and https://github.com/doctrine/DoctrineBundle/blob/2.0.x/DependencyInjection/Configuration.php#L95

I'm not very familiar with bundle configurations, but to me it looks like that at least the deprecation part needs to be moved from yaml to php to be able to dynamically use one or three arguments - depending on the Symfony version.

[Kynno]

Hey, any news on this?

[althaus]

Hey, any news on this?

No, to solve the issue the (relevant parts of the) configuration have to be moved from YAML to PHP. Otherwise you won't be able to support both variants. I don't see changing the config type in the scope of this PR, so feel free to create another issue. I'm pretty sure there tools out there which can automate the conversion.