Skip to content

refac: remove AbstractController from EditInPlaceController #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2022
Merged

refac: remove AbstractController from EditInPlaceController #459

merged 1 commit into from
Jan 20, 2022

Conversation

gimler
Copy link
Contributor

@gimler gimler commented Jan 20, 2022 •
edited
Loading

Fix deprecation

Since symfony/dependency-injection 5.1: The "Psr\Container\ContainerInterface" autowiring alias is deprecated. Define it explicitly in your app if you want to keep using it. It is being referenced by the "Translation\Bundle\Controller\EditInPlaceController" service.

related also to #455

bocharsky-bw
bocharsky-bw reviewed Jan 20, 2022
View reviewed changes
@gimler gimler force-pushed the feature/fix_deprecation branch from 993caef to 6f3a0e1 Compare January 20, 2022 11:51
@gimler gimler changed the title refac: use requestStack instate of session service refac: remove AbstractController from EditInPlaceController Jan 20, 2022
bocharsky-bw
bocharsky-bw approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@bocharsky-bw bocharsky-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix and understanding 👍

@bocharsky-bw bocharsky-bw merged commit 85806a7 into php-translation:master Jan 20, 2022
@bocharsky-bw bocharsky-bw mentioned this pull request Jan 20, 2022
Closed
@gimler gimler deleted the feature/fix_deprecation branch January 20, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@welcoMattic welcoMattic welcoMattic approved these changes

@bocharsky-bw bocharsky-bw bocharsky-bw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gimler @welcoMattic @bocharsky-bw