Skip to content

Use autowiring for SymfonyProfilerController #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 24, 2022
Merged

Use autowiring for SymfonyProfilerController #461

merged 2 commits into from
Jan 24, 2022

Conversation

bocharsky-bw
Copy link
Member

To simplify config, suggested idea by @rvanlaak here: #460 (comment)

rvanlaak
rvanlaak approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@rvanlaak rvanlaak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Autowire could also be moved to the defaults, so the arguments from the other service can also get removed.

@rvanlaak rvanlaak mentioned this pull request Jan 24, 2022
Merged
@bocharsky-bw
Copy link
Member Author

Thank you!

@bocharsky-bw bocharsky-bw merged commit d47279e into php-translation:master Jan 24, 2022
@bocharsky-bw bocharsky-bw deleted the profiler-controller-autowire branch January 24, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@welcoMattic welcoMattic welcoMattic approved these changes

@rvanlaak rvanlaak rvanlaak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bocharsky-bw @welcoMattic @rvanlaak