Skip to content

feat(fe): allow php 8.1, FE-3713 #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

QuodNephilim
Copy link

No description provided.

@rvanlaak
Copy link
Member

The existing ^8.0 clause should already cover this.

Also see PR #465 that enabled testing on 8.1

@QuodNephilim
Copy link
Author

Hi, @rvanlaak.
I have php >= 8.1 in composer.json, when I tried to install your package it was fault, so I did fork meanwhile, waiting for your release of 8.1 support.
Best regards.

@bocharsky-bw
Copy link
Member

bocharsky-bw commented Apr 22, 2022

@QuodNephilim see composer.json:

"php": "^7.2 || ^8.0",
- this already allows PHP 8.0 and 8.1 for this bundle, and actually any 8.x version of PHP too. Also, we do test this bundle on PHP 8.1, see our CI: https://github.com/php-translation/symfony-bundle/runs/5816280519?check_suite_focus=true

So, if you had an error requiring this bundle on PHP 8.1 - most probably it was an incompatible issue in your project, look closer to the error and what exactly packages cause this. Or, feel free to share the exact error you see, i.e. the whole Composer output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants