Skip to content

Create legacy class instead of method to improve performance #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 26, 2017
Merged

Create legacy class instead of method to improve performance #23

merged 1 commit into from
Dec 26, 2017

Conversation

bocharsky-bw
Copy link
Member

Instead of constantly checking if the method exists - check if class implements TranslationWriterInterface only once at runtime.

@Nyholm Nyholm self-requested a review December 25, 2017 20:05
Nyholm
Nyholm approved these changes Dec 26, 2017
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Nyholm Nyholm merged commit a09b4a4 into php-translation:master Dec 26, 2017
@bocharsky-bw bocharsky-bw deleted the legacy-translation-writer branch December 27, 2017 08:22
@bocharsky-bw
Copy link
Member Author

@Nyholm if you add a release tag for this, I'll be able to reuse this LegacyTranslationWriterin php-translation/symfony-bundle#145

@Nyholm
Copy link
Member

Nyholm commented Dec 27, 2017

Yes. I'll reviewed it and fix that within a few hours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bocharsky-bw @Nyholm