Skip to content

Fix code style #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 5, 2019
Merged

Fix code style #37

merged 3 commits into from
Dec 5, 2019

Conversation

rvanlaak
Copy link
Member

@rvanlaak rvanlaak commented Dec 5, 2019

to make CI green again before the next release.

related to https://github.styleci.io/analyses/3wOoer

@odolbeau
Copy link
Member

odolbeau commented Dec 5, 2019

I released 1.1.0 a bit too fast (https://github.com/php-translation/symfony-storage/releases/tag/1.1.0) :o
I you could remove Style CI, I'll replace it with github actions (php-cs-fixer + PHPStan) like in the bundle if it's OK for you?

@rvanlaak
Copy link
Member Author

rvanlaak commented Dec 5, 2019

Great idea. Did remove the config together with this PR. I'm unable to disable StyleCI though:
image

What about using https://github.com/jakzal/phpqa to make testing code style and phpstan reproducible locally?

@odolbeau
Copy link
Member

odolbeau commented Dec 5, 2019

What about using https://github.com/jakzal/phpqa to make testing code style and phpstan reproducible locally?

Sure, that's exactly what we use for the bundle: https://github.com/php-translation/symfony-bundle/blob/master/.github/workflows/static.yml :)

@odolbeau
Copy link
Member

odolbeau commented Dec 5, 2019

No it's not in fact! 🤔

@rvanlaak
Copy link
Member Author

rvanlaak commented Dec 5, 2019

@odolbeau see #38

@Nyholm
Copy link
Member

Nyholm commented Dec 5, 2019

StyleCI is disabled.

Im happy with merging this.
Im also happy with leaving the exception on multiple lines.

@rvanlaak rvanlaak closed this Dec 5, 2019
@rvanlaak rvanlaak reopened this Dec 5, 2019
@rvanlaak
Copy link
Member Author

rvanlaak commented Dec 5, 2019

Then let's merge this, the work of @odolbeau on php-cs-fixer probably will change the code style across the whole repo.

@rvanlaak rvanlaak merged commit 8f81c91 into master Dec 5, 2019
@odolbeau odolbeau deleted the styleci-fix branch December 6, 2019 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants