-
Notifications
You must be signed in to change notification settings - Fork 13
Fix code style #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix code style #37
Conversation
I released 1.1.0 a bit too fast (https://github.com/php-translation/symfony-storage/releases/tag/1.1.0) :o |
Great idea. Did remove the config together with this PR. I'm unable to disable StyleCI though: What about using https://github.com/jakzal/phpqa to make testing code style and phpstan reproducible locally? |
Sure, that's exactly what we use for the bundle: https://github.com/php-translation/symfony-bundle/blob/master/.github/workflows/static.yml :) |
No it's not in fact! 🤔 |
StyleCI is disabled. Im happy with merging this. |
Then let's merge this, the work of @odolbeau on |
to make CI green again before the next release.
related to https://github.styleci.io/analyses/3wOoer