No legacy #39
Merged
No legacy #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh. Interesting. I was just it would be a BC break. I’ll review this carefully shortly. |
|
We can use PHPStan's baseline feature to continue, so no worries about a dependency on that 👍 |
Nyholm
approved these changes
Dec 5, 2019
| * | ||
| * @author Tobias Nyholm <tobias.nyholm@gmail.com> | ||
| */ | ||
| class SymfonyPort |
There was a problem hiding this comment.
Is removing this class a BC break?
| @@ -58,18 +58,8 @@ final class FileStorage implements Storage, TransferableStorage | |||
| * @param array $dir | |||
| * @param array $options | |||
| */ | |||
| public function __construct($writer, $reader, array $dir, array $options = []) | |||
| public function __construct(TranslationWriterInterface $writer, TranslationReaderInterface $reader, array $dir, array $options = []) | |||
There was a problem hiding this comment.
Removing the possibility to use TranslationLoader here is a BC break Im afraid.
|
I merge this PR. TODO before v2:
|
Closed
|
Wohoo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of #32
It removes a lot of classes, it will be way easier to run php-cs-fixer & PHPStan! ^^
(Need a major release)