Fix #70359 and #78577 #11402
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| --TEST-- | ||
| Bug #70359 (print_r() on DOMAttr causes Segfault in php_libxml_node_free_list()) | ||
| --EXTENSIONS-- | ||
| dom | ||
| --FILE-- | ||
| <?php | ||
|
|
||
| echo "-- Test without parent --\n"; | ||
|
|
||
| $dom = new DOMDocument(); | ||
| $dom->loadXML(<<<XML | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9" xmlns:xsi="fooooooooooooooooooooo"/> | ||
| XML); | ||
| $spaceNode = $dom->documentElement->getAttributeNode('xmlns'); | ||
| print_r($spaceNode); | ||
|
|
||
| echo "-- Test with parent and non-ns attribute --\n"; | ||
|
|
||
| $dom = new DOMDocument(); | ||
| $dom->loadXML(<<<XML | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9"> | ||
| <url xmlns:xsi="fooooooooooooooooooooo" myattrib="bar"/> | ||
| </urlset> | ||
| XML); | ||
| $spaceNode = $dom->documentElement->firstElementChild->getAttributeNode('myattrib'); | ||
| var_dump($spaceNode->nodeType); | ||
| var_dump($spaceNode->nodeValue); | ||
|
|
||
| $dom->documentElement->firstElementChild->remove(); | ||
| try { | ||
| print_r($spaceNode->parentNode); | ||
| } catch (\Error $e) { | ||
| echo $e->getMessage(), "\n"; | ||
| } | ||
|
|
||
| echo "-- Test with parent and ns attribute --\n"; | ||
|
|
||
| $dom = new DOMDocument(); | ||
| $dom->loadXML(<<<XML | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9"> | ||
| <url xmlns:xsi="fooooooooooooooooooooo" myattrib="bar"/> | ||
| </urlset> | ||
| XML); | ||
| $spaceNode = $dom->documentElement->firstElementChild->getAttributeNode('xmlns:xsi'); | ||
| print_r($spaceNode); | ||
|
|
||
| $dom->documentElement->firstElementChild->remove(); | ||
| var_dump($spaceNode->parentNode->nodeName); // Shouldn't crash | ||
|
|
||
| ?> | ||
| --EXPECT-- | ||
| -- Test without parent -- | ||
| DOMNameSpaceNode Object | ||
| ( | ||
| [nodeName] => xmlns | ||
| [nodeValue] => http://www.sitemaps.org/schemas/sitemap/0.9 | ||
| [nodeType] => 18 | ||
| [prefix] => | ||
| [localName] => xmlns | ||
| [namespaceURI] => http://www.sitemaps.org/schemas/sitemap/0.9 | ||
| [ownerDocument] => (object value omitted) | ||
| [parentNode] => (object value omitted) | ||
| ) | ||
| -- Test with parent and non-ns attribute -- | ||
| int(2) | ||
| string(3) "bar" | ||
| Couldn't fetch DOMAttr. Node no longer exists | ||
| -- Test with parent and ns attribute -- | ||
| DOMNameSpaceNode Object | ||
| ( | ||
| [nodeName] => xmlns:xsi | ||
| [nodeValue] => fooooooooooooooooooooo | ||
| [nodeType] => 18 | ||
| [prefix] => xsi | ||
| [localName] => xsi | ||
| [namespaceURI] => fooooooooooooooooooooo | ||
| [ownerDocument] => (object value omitted) | ||
| [parentNode] => (object value omitted) | ||
| ) | ||
| string(3) "url" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| --TEST-- | ||
| Bug #78577 (Crash in DOMNameSpace debug info handlers) | ||
| --EXTENSIONS-- | ||
| dom | ||
| --FILE-- | ||
| <?php | ||
|
|
||
| $doc = new DOMDocument; | ||
| $doc->loadXML('<foo xmlns="http://php.net/test" xmlns:foo="urn:foo" />'); | ||
|
|
||
| $attr = $doc->documentElement->getAttributeNode('xmlns'); | ||
| var_dump($attr); | ||
|
|
||
| ?> | ||
| --EXPECT-- | ||
| object(DOMNameSpaceNode)#3 (8) { | ||
| ["nodeName"]=> | ||
| string(5) "xmlns" | ||
| ["nodeValue"]=> | ||
| string(19) "http://php.net/test" | ||
| ["nodeType"]=> | ||
| int(18) | ||
| ["prefix"]=> | ||
| string(0) "" | ||
| ["localName"]=> | ||
| string(5) "xmlns" | ||
| ["namespaceURI"]=> | ||
| string(19) "http://php.net/test" | ||
| ["ownerDocument"]=> | ||
| string(22) "(object value omitted)" | ||
| ["parentNode"]=> | ||
| string(22) "(object value omitted)" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| --TEST-- | ||
| DOMXPath::query() can return DOMNodeList with DOMNameSpaceNode items - advanced variation | ||
| --EXTENSIONS-- | ||
| dom | ||
| --FILE-- | ||
| <?php | ||
|
|
||
| $dom = new DOMDocument(); | ||
| $dom->loadXML(<<<'XML' | ||
| <root xmlns:foo="http://example.com/foo" xmlns:bar="http://example.com/bar"> | ||
| <child xmlns:baz="http://example.com/baz">Hello PHP!</child> | ||
| </root> | ||
| XML); | ||
|
|
||
| $xpath = new DOMXPath($dom); | ||
| $query = '//namespace::*'; | ||
|
|
||
| echo "-- All namespace attributes --\n"; | ||
|
|
||
| foreach ($xpath->query($query) as $attribute) { | ||
| echo $attribute->nodeName . ' = ' . $attribute->nodeValue . PHP_EOL; | ||
| var_dump($attribute->parentNode->tagName); | ||
| } | ||
|
|
||
| echo "-- All namespace attributes with removal attempt --\n"; | ||
|
|
||
| foreach ($xpath->query($query) as $attribute) { | ||
| echo "Before: ", $attribute->parentNode->tagName, "\n"; | ||
| // Second & third attempt should fail because it's no longer in the document | ||
| try { | ||
| $attribute->parentNode->remove(); | ||
| } catch (\DOMException $e) { | ||
| echo $e->getMessage(), "\n"; | ||
| } | ||
| // However, it should not cause a use-after-free | ||
| echo "After: ", $attribute->parentNode->tagName, "\n"; | ||
| } | ||
|
|
||
| ?> | ||
| --EXPECT-- | ||
| -- All namespace attributes -- | ||
| xmlns:xml = http://www.w3.org/XML/1998/namespace | ||
| string(4) "root" | ||
| xmlns:bar = http://example.com/bar | ||
| string(4) "root" | ||
| xmlns:foo = http://example.com/foo | ||
| string(4) "root" | ||
| xmlns:xml = http://www.w3.org/XML/1998/namespace | ||
| string(5) "child" | ||
| xmlns:bar = http://example.com/bar | ||
| string(5) "child" | ||
| xmlns:foo = http://example.com/foo | ||
| string(5) "child" | ||
| xmlns:baz = http://example.com/baz | ||
| string(5) "child" | ||
| -- All namespace attributes with removal attempt -- | ||
| Before: root | ||
| After: root | ||
| Before: root | ||
| Not Found Error | ||
| After: root | ||
| Before: root | ||
| Not Found Error | ||
| After: root | ||
| Before: child | ||
| After: child | ||
| Before: child | ||
| Not Found Error | ||
| After: child | ||
| Before: child | ||
| Not Found Error | ||
| After: child | ||
| Before: child | ||
| Not Found Error | ||
| After: child |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit you probably want to remove the trailing
/* {{{ */comment