RFC: Deprecate type juggling to and from bool for function type juggling context #18879
+2,081
−8,401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Category: Engine
Extension: opcache
Extension: phar
ABI break
labels
Girgias
added a commit
to php/doc-en
that referenced
this pull request
Jun 19, 2025
Found while working on php/php-src#18879
This was referenced Jun 20, 2025
Girgias
force-pushed
the
bool-juggling-dep-poc
branch
from
0e1de90 to
abacde3
Compare
Girgias
added a commit
that referenced
this pull request
Jun 21, 2025
- Use INI sections - Use CGI sections - Move data into a subfolder - Remove ZPP tests - Fix various bugs within tests - Simplify some Found while working on #18879
Girgias
force-pushed
the
bool-juggling-dep-poc
branch
from
abacde3 to
8f5f75b
Compare
Girgias
force-pushed
the
bool-juggling-dep-poc
branch
from
8f5f75b to
6487506
Compare
Need to update ext/phar/tests/file/nophar.phar somehow to remove the deprecation...
Girgias
force-pushed
the
bool-juggling-dep-poc
branch
from
6487506 to
84936a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC: https://wiki.php.net/rfc/deprecate-function-bool-type-juggling
@nicolas-grekas this should allow you to check if SF is affected :)