planner: set the default of the tidb_cost_model_version correctly #61608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
ti-chi-bot
bot
added
do-not-merge/needs-tests-checked
release-note-none
hawkingrei
changed the title
ti-chi-bot
bot
added
release-note
hawkingrei
commented
Jun 9, 2025
| @@ -87,6 +88,7 @@ func (p *PhysicalProjection) GetCost(count float64) float64 { | |||
|
|
|||
| // GetPlanCostVer1 calculates the cost of the plan if it has not been calculated yet and returns the cost. | |||
| func (p *PhysicalProjection) GetPlanCostVer1(taskType property.TaskType, option *optimizetrace.PlanCostOption) (float64, error) { | |||
| intest.Assert(p.SCtx().GetSessionVars().CostModelVersion != 0) | |||
There was a problem hiding this comment.
CostModelVersion's value is only 1 or 2, so if we get 0, it has a problem.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #61608 +/- ##
================================================
+ Coverage 73.1044% 73.5543% +0.4498%
================================================
Files 1729 1729
Lines 481039 481130 +91
================================================
+ Hits 351661 353892 +2231
+ Misses 107839 105751 -2088
+ Partials 21539 21487 -52
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
tiancaiamao
changed the title
qw4990
approved these changes
Jun 10, 2025
tiancaiamao
approved these changes
Jun 10, 2025
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
yudongusa
approved these changes
Jun 10, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qw4990, tiancaiamao, yudongusa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
AilinKid
pushed a commit
to AilinKid/tidb
that referenced
this pull request
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #61565
Problem Summary:
What changed and how does it work?
We don't set the default of the tidb_cost_model_version in the right place. so it led many problems in the internal SQL. The internal SQL will not use the cost model v2.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.