Skip to content

Added code block #4753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from Apr 30, 2020
Merged

Added code block #4753

merged 2 commits into from Apr 30, 2020

Conversation

ghost
Copy link

@ghost ghost commented Apr 10, 2020

Thanks for your interest in plotly.js!

Translations:

  • Make a PR directly to the main repository
  • Please @ mention a few other speakers of this language who can help review your translations.
  • If you've omitted any keys from dist/translation_keys.txt - which means they will fall back on the US English text - just make a short comment about why in the PR description: the English text works fine in your language, or you would like someone else to help translating those, or whatever the reason.
  • You should only update files in lib/locales/, not those in dist/

Features, Bug fixes, and others:

Developers are strongly encouraged to first make a PR to their own plotly.js fork and ask one of the maintainers to review the modifications there. Once the pull request is deemed satisfactory, the developer will be asked to make a pull request to the main plotly.js repo and may be asked to squash some commits before doing so.

Before opening a pull request, developer should:

  • git rebase their local branch off the latest master,
  • make sure to not git add the dist/ folder (the dist/ is updated only on version bumps),
  • make sure to commit changes to the package-lock.json file (if any),
  • write an overview of what the PR attempts to do,
  • select the Allow edits from maintainers option (see this article for more details).

Note that it is forbidden to force push (i.e. git push -f) to remote branches associated with opened pull requests. Force pushes make it hard for maintainers to keep track of updates. Therefore, if required, please git merge master into your PR branch instead of git rebase master.

Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Thanks @nainardev - nice update!

@alexcjohnson alexcjohnson merged commit b83c5cb into plotly:master Apr 30, 2020
@ghost ghost deleted the patch-1 branch April 30, 2020 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant