Skip to content

Diagnostics app #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 35 commits into from
May 6, 2024
Merged

Diagnostics app #151

merged 35 commits into from
May 6, 2024

Conversation

benitav
Copy link
Contributor

@benitav benitav commented Apr 30, 2024 •
edited
Loading

Initial release of tools/diagnostics-app

benitav
benitav commented Apr 30, 2024
View reviewed changes
benitav
benitav commented Apr 30, 2024
View reviewed changes
benitav
benitav commented Apr 30, 2024
View reviewed changes
@benitav benitav requested review from rkistner and stevensJourney and removed request for rkistner May 2, 2024 07:50
@DominicGBauer
Copy link
Contributor

DominicGBauer commented May 3, 2024 •
edited
Loading

Should the diagnostics app not be in its own folder instead of demos?

@benitav
Copy link
Contributor Author

benitav commented May 3, 2024

Should the diagnostics app not be in its own folder instead of demos?

Are you thinking an apps folder to distinguish examples/demos from apps that developers can use? If so, I don't feel strongly about it at this point, since we currently just have one of these. If we publish more it might make sense.

@rkistner
Copy link
Contributor

rkistner commented May 3, 2024

Should the diagnostics app not be in its own folder instead of demos?

Also happy for other suggestions - I just placed it there since it followed the same structure as other demos.

@DominicGBauer
Copy link
Contributor

I would say tools instead of apps since tools are probably the only apps we will make.

stevensJourney
stevensJourney reviewed May 6, 2024
View reviewed changes
stevensJourney
stevensJourney previously approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@stevensJourney stevensJourney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is a very cool tool.

@rkistner rkistner mentioned this pull request May 6, 2024
Merged
@benitav benitav merged commit 49299b6 into main May 6, 2024
@benitav benitav deleted the diagnostics-app branch May 6, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkistner rkistner rkistner approved these changes

@stevensJourney stevensJourney stevensJourney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benitav @DominicGBauer @rkistner @stevensJourney