Skip to content

fix: use correct parameters variable in memoized params #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 2, 2024
Merged

fix: use correct parameters variable in memoized params #152

merged 2 commits into from
May 2, 2024

Conversation

DominicGBauer
Copy link
Contributor

No description provided.

@DominicGBauer DominicGBauer requested a review from rkistner May 2, 2024 10:07
@DominicGBauer DominicGBauer self-assigned this May 2, 2024
rkistner
rkistner reviewed May 2, 2024
View reviewed changes
Copy link
Contributor

@rkistner rkistner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar issue on line 88:

await powerSync.getAll<T>(sqlStatement, parameters);

@DominicGBauer DominicGBauer requested a review from rkistner May 2, 2024 10:17
@DominicGBauer DominicGBauer merged commit 7a05cae into main May 2, 2024
@DominicGBauer DominicGBauer deleted the fix/parameters branch May 2, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkistner rkistner rkistner approved these changes

Assignees

@DominicGBauer DominicGBauer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DominicGBauer @rkistner