Skip to content

feat: Exposing upload and download errors in SyncStatus #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 2, 2025

Conversation

Chriztiaan
Copy link
Contributor

@Chriztiaan Chriztiaan commented Mar 31, 2025

Added extra information fields to SyncStatus, similar to dart API.

Copy link

changeset-bot bot commented Mar 31, 2025

🦋 Changeset detected

Latest commit: 49b64b9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@powersync/common Minor
@powersync/node Patch
@powersync/op-sqlite Patch
@powersync/react-native Patch
@powersync/tanstack-react-query Patch
@powersync/web Patch
@powersync/diagnostics-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Chriztiaan Chriztiaan marked this pull request as ready for review April 1, 2025 06:26
Copy link
Collaborator

@stevensJourney stevensJourney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good to me so far.

It should be possible add unit tests, at least for the upload error reporting.

@Chriztiaan
Copy link
Contributor Author

Overall this looks good to me so far.

It should be possible add unit tests, at least for the upload error reporting.

@stevensJourney, I've added 2 simple sync status tests which are just a minor extensions of the existing stream tests we have. They are under web for the moment, but I think we can do some work/mocking in the future to be able to move these kinds of tests to common.

@Chriztiaan Chriztiaan merged commit b722378 into main Apr 2, 2025
6 checks passed
@Chriztiaan Chriztiaan deleted the feat/sync-status-errors branch April 2, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants