Fix new sync client with RNQS #636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 450b2c9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/react-native/src/sync/bucket/ReactNativeBucketStorageAdapter.ts
Show resolved
Hide resolved
stevensJourney
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reasons I don't fully understand, the array buffers we get from the RSocket package can't be passed to RNQS directly (it doesn't recognize them as array buffers and binds parameters to null). So, we copy once more.
I've also used this to benchmark syncing 1M rows once more (using RNQS with the demo todolist app and again with the barebones op-sqlite app). The sync is with an app launched using
pnpm ioson an simulator and a sync service + Postgres on localhost. I've reinstalled the app before each run. Note that the checkpoint applies extremely slowely on the todolist app because there are FTS5 triggers.I thought fine-tuning the backpressure handling with RSocket might speed things up even further (and there's still a bit of a "stop and go" behavior visible from sync progress), but increasing the local buffer or raising the watermark did not improve things. Anyway, the results are very promising already.