Fix watch query table names #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkistner
previously approved these changes
Jul 15, 2024
rkistner
approved these changes
Jul 15, 2024
mugikhan
added a commit
that referenced
this pull request
Jul 17, 2024
* Readme update: Messaging/description of powersync * remove duplicate word * Load and use PowerSync rust extension (#92) * Initial extension testing. * Replace schema logic with rust extension. * Use extension for saving operations. * Auto tx_id. * Use sync_local op. * Validate checksums using extension. * clear_remove_ops * delete_pending_buckets * delete_bucket * Fix deadlock on closing of connection. * WIP. * Update/fix tests. * Add view name override. * Retry opening database if locked. * Fix lint issues. * Use higher-level `updateSchema` in tests; test viewName alias. * Load extension for android and iOS * Load extension for iOS, MacOS and Android * Include powersync_flutter_libs * Rename android package * Update windows and linux extension scripts * Download binary in cmake * Fix arch in cmake * Fix binary download * Load extension on windows * Clean up readme and changelog * Remove test code * Update Abi check for current platform * Clean up unused files * Update path dependencies * Test downloading powersync binary for tests * Fix download for linux binary * Add binary download for demos workflow * Download latest binaries * Bump version of powersync * Bump minor version --------- Co-authored-by: Ralf Kistner <ralf@journeyapps.com> * Upgrade powersync-sqlite-core to version 0.1.7 for Android (#95) * Upgrade sqlite-core to version 0.1.7 for Android Upgrade powersync flutter libs to version 0.1.0 * Update demos versions * Bump powersync version (#96) * Update existing changelog message for powersync (#97) * Override default macOS SQLite for tests (#99) * Override default macOS sqlite db for tests * Update to use flutter test rather than dart test * Added documentation * Check if abort future is completed before completing it (#100) * Check if abort future is completed before completing it * Bump powersync version * Upgrade sqlite_async (#105) * Use updated sqlite_async package * Update to CommonDatabase for sqlite_async * Update open DB to be synchronous * Upgrade sqlite_async. Update changelog and bump versions * Fix linting errors * boilerplate * the app :) * more boilerplate * fix deps and rename app name * bump to latest sqlite_async * chore: fix pana score checks (#110) * snake_case apiclient * fix `dart analyze` output * `dart format` * Add hasSynced and waitForFirstSync (#112) * Add hasSynced and waitForFirstSync * Export sqlite3_common * Add example code for hasSynced Bump version * Close http connections immediately on disconnect. * Fix some errors when closing client while connecting. * Remove retry delay when aborting. * More accurate connection counts. * Fix Future already completed when calling waitForFirstSync (#117) * Ensure future is not completed * Bump version * Add changelog entry for issue 114. * Iterate through stream instead of listening to it * Fix changelog message --------- Co-authored-by: Ralf Kistner <ralf@journeyapps.com> * [Feature] Added user parameters support when connecting (#98) * Added support for user parameters on connection * Added changelog notes and updated demos. * Updated .connect() signature to match powersync-js. * [Chore] Update Django Demo Readme (#120) * update Django readme * remove unneeded override (#121) * Remove unusued imports * Update sqlite3 wasm Script to download core for testing * Add updateHasSynced to db_mixin Pr feedback and cleanup * Fix hasSynced status * Make client params public * Abort sync on aborted disconnect * fix bug in setStatus * Fix native powersync_flutter_libs dependency * Add powersync_init on database init * Update js dependency * Update supabase_flutter * Download core binary with dart script instead of github action * Fix watch query table names (#123) * Fix watch query table names * Add to changelog * Fix check for null or empty triggerOnTables * Upgrade sqlite_async version for attachments helper * [Fix] Offline has synced (#124) * fix offline has synced * Add watch query table names fix * Add chrome test * Remove internalTrackedWrite for web database * Increase 'Multiple calls to disconnect' test timeout * Remove timeout and separate flutter and dart tests * Complete abort on disconnect --------- Co-authored-by: Conrad Hofmeyr <cahofmeyr@gmail.com> Co-authored-by: Ralf Kistner <ralf@journeyapps.com> Co-authored-by: Kobie Botha <kobie@journeyapps.com> Co-authored-by: stevensJourney <51082125+stevensJourney@users.noreply.github.com> Co-authored-by: Christiaan Landman <chriz.ek@gmail.com> Co-authored-by: Dieter Plaetinck <dieter@plaetinck.be> Co-authored-by: Steven Ontong <steven@journeyapps.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses the enhancement in #116 with
watchqueries not recognizing powersync table names.Work done
triggerOnTablesparameter in a watch query.sqlite_asyncto 0.8.1