Skip to content

Upgrade to rubocop v1 #3378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Upgrade to rubocop v1 #3378

wants to merge 6 commits into from

Conversation

jonrohan
Copy link
Member

What are you trying to accomplish?

This PR upgrades the RuboCop gem to version 1.73 and migrates the linters to use the new RuboCop::Cop::Base class and extend AutoCorrector. I followed the migration guide in https://docs.rubocop.org/rubocop/v1_upgrade_notes.html

Screenshots

Integration

List the issues that this change affects.

Closes #3351

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@jonrohan jonrohan requested a review from a team as a code owner March 11, 2025 19:08
@jonrohan jonrohan requested a review from siddharthkp March 11, 2025 19:08
Copy link

changeset-bot bot commented Mar 11, 2025

🦋 Changeset detected

Latest commit: 6961be7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

@github-actions github-actions bot added the Stale Automatically marked as stale. label May 10, 2025
@github-actions github-actions bot closed this May 17, 2025
@github-actions github-actions bot deleted the upgrade_rubocop branch May 17, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch release Stale Automatically marked as stale.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade rubocop cops to v1
1 participant