Compare locales bug 1382622 #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sadly we don't use tox in automation, need to dig into travis to actually get test coverage. |
|
This works, https://travis-ci.org/projectfluent/python-fluent/builds/270754036?utm_source=github_status&utm_medium=notification. It does run both 2.7 tests in one worker, but the thing that costs time here is setup anyway, so this doesn't affect wall-clock time. I'd squash commit 1 and 3 here before landing. I think leaving commit 2 separate makes sense. |
stasm
approved these changes
Sep 1, 2017
… r=stas compare-locales doesn't support py3 yet, so we don't add that environment yet. This adds tox-travis, so that we can add dependency management in tox, and use travis to run individual jobs per python version. Compare-locales or not are run in the same travis job.
The get_val wasn't really intended to be an API to begin with. Using the property .val is forwards and backwards compatible.
Pike
force-pushed
the
compare-locales-bug-1382622
branch
from
bb93248 to
14bf8de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add testing for python 2.7 with compare-locales and without. As compare-locales doesn't support py3, we don't do that for 3.6 yet.
The test failures were just in the actual test code, so this fix is low-impact.