Skip to content

Demo a flag-based tooling parser #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Pike
Copy link
Contributor

@Pike Pike commented Nov 13, 2018

Stas, this would be a feedback? in old bugzilla days ;-)

A very rudimentary start at a syntax-detecting tooling parser.

I tested it locally against

# Foo
foo =  bar

[[joe]]
bar = hi

and master parses a GroupComment and this branch gives a Junk for the [[joe]] line.

Questions:
Is this something you'd like me to spend time on?
I chose a separation between features and syntaxes, to make the code easier to understand, but also pave the way for future versions where there's overlap between syntaxes. Does that make sense?

@stasm
Copy link
Contributor

stasm commented Mar 11, 2019

With #107 merged, this PR can be closed. We ended up removing the support for old syntax from the parser and thus not having to implement the flag-based approach.

@stasm stasm closed this Mar 11, 2019
@Pike Pike deleted the feature-switch branch March 11, 2019 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants