Skip to content

(maint) Fix CI issue where acceptance tests fail on SLES #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2017

Conversation

wilson208
Copy link
Contributor

@wilson208 wilson208 commented Mar 20, 2017

Caused by float passed to versioncmp function which expects a string, which is only executed when OS == SLES

Introduced by PR #851 which only surfaced when running against SLES.

Caused by float passed to versioncmp function which expects a string, which is only executed when OS == SLES
@pmcmaw
Copy link
Contributor

pmcmaw commented Mar 20, 2017

Looks good to me! 👍

@pmcmaw pmcmaw merged commit 46dad7a into puppetlabs:master Mar 20, 2017
@HelenCampbell
Copy link
Contributor

+1

@wilson208 wilson208 deleted the ci-fix branch March 28, 2017 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants