(MODULES-4558) Add support for --data-checksums on initdb #855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binford2k
changed the title
|
Could you rebase this into a single commit? |
|
Done. I also added the new option |
|
is this the same functionality as #878? |
|
@mmoll Yes So this PR have been open almost half a year (also used in production), and then this similar PR (#878) gets merged after just 3 days? Looks like the other PR misses the version check as well. Come on guys 👎 |
|
@atmoz could you rebase/rework that PR so the additional check can get in? |
|
got in via GH-915, so this PR can get closed |
|
Sorry about the slowness. Thanks for your patience @atmoz and apologies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tickets.puppetlabs.com/browse/MODULES-4558