defaulted psql_path to postgresql::server::psql_path #947
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
psql_path
variable declared within thepostgresql::server::service
class defaults by calling the default directly fromparams
rather than from the parent service class like other variables. Since these are not parameters, this makespsql_path
impossible to override using class params/hiera. It looks like this was done in error as$postgresql::server::psql_path
exists and defaults to the params entry.This fix defaults it to
$postgresql::server::psql_path
and should give the same default behavour but allow you to overridepostgresql::server::psql_path: foo
in Hiera.