Skip to content

defaulted psql_path to postgresql::server::psql_path #947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2018

Conversation

crayfishx
Copy link
Contributor

The psql_path variable declared within the postgresql::server::service class defaults by calling the default directly from params rather than from the parent service class like other variables. Since these are not parameters, this makes psql_path impossible to override using class params/hiera. It looks like this was done in error as $postgresql::server::psql_path exists and defaults to the params entry.

This fix defaults it to $postgresql::server::psql_path and should give the same default behavour but allow you to override postgresql::server::psql_path: foo in Hiera.

@david22swan david22swan merged commit ebaf270 into puppetlabs:master Jan 11, 2018
@ubellavance
Copy link

I don't know if it's related, but I'm trying to use the module with the postgresql package from SCL and it has weird paths. For example, psql is at /opt/rh/rh-postgresql96/root/usr/bin/psql. If I try to use the module, the connection validator fails, most likely because it cannot find the psql binary. I don't know how to override it.

@ubellavance
Copy link

Nevermind, it looked it worked OK. The problem is that when it calls psql from the SCL package, it cannot find a shared object. I installed the non-SCL psql and removed my psql_path entry and it works ok.

@hunner hunner added the bugfix label Mar 29, 2018
cegeka-jenkins pushed a commit to cegeka/puppet-postgresql that referenced this pull request Feb 3, 2022
defaulted psql_path to postgresql::server::psql_path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants