Skip to content

Bump url from 2.5.2 to 2.5.4 #1585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 12, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 4 additions & 44 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ serde = { version = "1.0.217", features = ["derive"] }
speedate = "0.15.0"
smallvec = "1.13.2"
ahash = "0.8.10"
url = "2.5.0"
url = "2.5.4"
# idna is already required by url, added here to be explicit
idna = "1.0.3"
base64 = "0.22.1"
Expand Down
12 changes: 6 additions & 6 deletions tests/validators/test_url.py
Original file line number Diff line number Diff line change
Expand Up @@ -125,9 +125,9 @@ def url_test_case_helper(
('http://1...1', Err('invalid IPv4 address')),
('https://[2001:0db8:85a3:0000:0000:8a2e:0370:7334[', Err('invalid IPv6 address')),
('https://[', Err('invalid IPv6 address')),
('https://example com', Err('invalid domain character')),
('http://exam%ple.com', Err('invalid domain character')),
('http:// /', Err('invalid domain character')),
('https://example com', Err('invalid international domain name')),
('http://exam%ple.com', Err('invalid international domain name')),
('http:// /', Err('invalid international domain name')),
('/more', Err('relative URL without a base')),
('http://example.com./foobar', {'str()': 'http://example.com./foobar'}),
# works since we're in lax mode
Expand Down Expand Up @@ -172,7 +172,7 @@ def url_test_case_helper(
('https:more', {'str()': 'https://more/', 'host': 'more'}),
('file:///foobar', {'str()': 'file:///foobar', 'host': None, 'unicode_host()': None}),
('file:///:80', {'str()': 'file:///:80'}),
('file://:80', Err('invalid domain character')),
('file://:80', Err('invalid international domain name')),
('foobar://:80', Err('empty host')),
# with bashslashes
('file:\\\\foobar\\more', {'str()': 'file://foobar/more', 'host': 'foobar', 'path': '/more'}),
Expand Down Expand Up @@ -383,7 +383,7 @@ def strict_url_validator_fixture():
('https:/more', Err('expected //', 'url_syntax_violation')),
('https:more', Err('expected //', 'url_syntax_violation')),
('file:///foobar', {'str()': 'file:///foobar', 'host': None, 'unicode_host()': None}),
('file://:80', Err('invalid domain character', 'url_parsing')),
('file://:80', Err('invalid international domain name', 'url_parsing')),
('file:/xx', Err('expected // after file:', 'url_syntax_violation')),
('foobar://:80', Err('empty host', 'url_parsing')),
('mongodb+srv://server.example.com/', 'mongodb+srv://server.example.com/'),
Expand Down Expand Up @@ -1046,7 +1046,7 @@ def test_zero_schemas():
(
'http://127.0.0.1%0d%0aConnection%3a%20keep-alive',
# dict(scheme='http', host='127.0.0.1%0d%0aconnection%3a%20keep-alive'), CHANGED
Err('Input should be a valid URL, invalid domain character [type=url_parsing,'),
Err('Input should be a valid URL, invalid international domain name [type=url_parsing,'),
),
# NodeJS unicode -> double dot
('http://google.com/\uff2e\uff2e/abc', dict(scheme='http', host='google.com', path='/%EF%BC%AE%EF%BC%AE/abc')),
Expand Down
Loading