Skip to content

update to speedate 0.16 #1740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025
Merged

update to speedate 0.16 #1740

merged 1 commit into from
Jun 16, 2025

Conversation

davidhewitt
Copy link
Contributor

Change Summary

Updates to speedate 0.16.

Does not add support for the new timestamp unit setting (cc @ollz272, I understood you have a branch for that).

Related issue number

N/A

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Copy link

codspeed-hq bot commented Jun 16, 2025

CodSpeed Performance Report

Merging #1740 will improve performances by 16.28%

Comparing dh/speedate-0.16 (b907422) with main (3415428)

Summary

⚡ 1 improvements
✅ 156 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_many_models_core_model 2.5 ms 2.2 ms +16.28%

@ollz272
Copy link
Contributor

ollz272 commented Jun 16, 2025

#1741 here for you 😄 (just waiting for checks to pass before moving out of draft)

@ollz272
Copy link
Contributor

ollz272 commented Jun 16, 2025

Just noticed that you've made the changes needed here as well, think we've got similar implementations, will approve this one 👍🏻

@davidhewitt davidhewitt merged commit d9dacb0 into main Jun 16, 2025
31 checks passed
@davidhewitt davidhewitt deleted the dh/speedate-0.16 branch June 16, 2025 16:27
@davidhewitt
Copy link
Contributor Author

Thanks, merged this one. I guess the follow up is to expose a new configuration option to control the timestamp parsing from Python?

@davidhewitt
Copy link
Contributor Author

(Did I understand you're already working on that?)

@ollz272
Copy link
Contributor

ollz272 commented Jun 17, 2025

@davidhewitt Sorry, i must have not been clear, i meant i had a pr for this bit of work 😓

Happy to work on it though may take a bit of time given the larger scope of it now - can probably chip away at it bit by bit though

@davidhewitt
Copy link
Contributor Author

Sure thing, no rush and much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants