Skip to content

Registration #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Jul 31, 2023
Merged

Registration #11

merged 29 commits into from
Jul 31, 2023

Conversation

ArtyomVancyan
Copy link
Member

@ArtyomVancyan ArtyomVancyan commented Jul 16, 2023

Motivation:

This PR was mainly committed to adding registration support or providing a way of connecting OAuth users with the existing ORM. But it has changed the following behaviors as well:

  • Middleware can obtain an optional callback for calling after authentication success.
  • Changed some design solutions that were made before.
  • At the code level: fixed all typing issues and added missing ones. Also, added missing descriptions to classes.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you updated the documentation related to the changes you have made?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

Performing user onboarding - The callback sample checks for user's existence and creates if there is no such user with the given identity.
@ArtyomVancyan ArtyomVancyan marked this pull request as ready for review July 31, 2023 19:03
@ArtyomVancyan ArtyomVancyan merged commit 7110ea0 into pysnippet:master Jul 31, 2023
@ArtyomVancyan ArtyomVancyan deleted the registration branch July 31, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant