-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Fixture split 2nd attempt #1710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixture split 2nd attempt #1710
Conversation
I see this also fixes #1125 |
oh, i didn't notice ^^ i'll need some more code moves tho |
@RonnyPfannschmidt you think it is worth doing it now, since this PR is moving a lot of code around anyway? 😁 |
doing a second one helped getting faster with it but i wouldn't mind deferring should it turn necessary |
Oh my this completely broke my invocation-scope branch... I thought Git would keep track better of those things. 😭 |
@nicoddemus a |
Nope, that's what I meant with "broke my branch"... Git didn't track my changes at all :( |
@RonnyPfannschmidt did you change anything or just moved code around? I'm getting a strange failure in doctest after trying to apply my changes into the new branch... |
i only moved code, please show the failure |
No worries, I will try to figure it out tomorrow |
Found the problem, by mistake I missed some lines when applying the patch. 😅 |
No description provided.