Address review: revert Py_CLEAR change in lru_list_elem_dealloc

Erlend E. Aasland · Erlend E. Aasland · commit f9ac4c5cbae4 · 2021-05-27T20:18:13.000+02:00
diff --git a/Modules/_functoolsmodule.c b/Modules/_functoolsmodule.c
@@ -766,8 +766,8 @@ static void
 lru_list_elem_dealloc(lru_list_elem *link)
 {
     PyTypeObject *tp = Py_TYPE(link);
-    Py_CLEAR(link->key);
-    Py_CLEAR(link->result);
+    Py_XDECREF(link->key);
+    Py_XDECREF(link->result);
     tp->tp_free(link);
     Py_DECREF(tp);
 }

Original file line number	Diff line number	Diff line change
`@@ -766,8 +766,8 @@ static void`
`766`	`766`	`lru_list_elem_dealloc(lru_list_elem *link)`
`767`	`767`	`{`
`768`	`768`	`PyTypeObject *tp = Py_TYPE(link);`
`769`		`- Py_CLEAR(link->key);`
`770`		`- Py_CLEAR(link->result);`
	`769`	`+ Py_XDECREF(link->key);`
	`770`	`+ Py_XDECREF(link->result);`
`771`	`771`	`tp->tp_free(link);`
`772`	`772`	`Py_DECREF(tp);`
`773`	`773`	`}`