-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
gh-107028: tiny textual changes in logging docs and docstrings #107029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-107028: tiny textual changes in logging docs and docstrings #107029
Conversation
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've suggested a few tweaks.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Hi @evildmp , I think our reviews crossed. Hopefully @JochemBoersma can use the best of both sets of suggestions. |
Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
Hi @vsajip . Thanks for review. To be honest, and for your information: for me the first time to contribute to a project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. (It can always be further improved of course.)
I have made the requested changes; please review again |
Thanks for making the requested changes! @vsajip: please review the changes made to this pull request. |
Thanks @JochemBoersma for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Thanks @JochemBoersma for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
GH-107065 is a backport of this pull request to the 3.12 branch. |
…ythonGH-107029) (cherry picked from commit 5e5a34a) Co-authored-by: Jochem Boersma <jochem.boersma@witteveenbos.com>
GH-107066 is a backport of this pull request to the 3.11 branch. |
…ythonGH-107029) (cherry picked from commit 5e5a34a) Co-authored-by: Jochem Boersma <jochem.boersma@witteveenbos.com>
…GH-107029) (GH-107065) (cherry picked from commit 5e5a34a)
…GH-107029) (GH-107066) (cherry picked from commit 5e5a34a)
|
I've done a tiny change in docstrings, to make documentation in line with the actual behavior of the function.
logger.handlers.MemoryHandler
methodflush()
#107028📚 Documentation preview 📚: https://cpython-previews--107029.org.readthedocs.build/