bpo-36952: remove bufsize keyword (deprecated 3.6, removed 3.8) #13400
Conversation
This keyword is marked as deprecated since 3.6 and for removal in 3.8. It already had no effects.
|
Asking for review from @serhiy-storchaka, as he added the deprecation warning. |
Doc/whatsnew/3.8.rst
Outdated
| @@ -821,6 +821,10 @@ The following features and APIs have been removed from Python 3.8: | |||
| exposed to the user. | |||
| (Contributed by Aviv Palivoda in :issue:`30262`.) | |||
|
|
|||
| * The ``bufsize`` keyword argument of :func:`fileinput.input` and | |||
| :func:`fileinput.FileInput` which was ignored and deprecated since Python 3.6 | |||
| has been removed. :issue:`36952` | |||
There was a problem hiding this comment.
Add "(Contributed by ...)" as in other entries.
Lib/test/test_fileinput.py
Outdated
|
|
||
| def buffer_size_test(self, t1, t2, t3, t4, bs=0, round=0): | ||
| def buffer_size_test(self, t1, t2, t3, t4, round=0): |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Have mock follow same API with kwonly params
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @serhiy-storchaka: please review the changes made to this pull request. |
|
Thanks, I've taken into account all the recommendations. |
Carreau
force-pushed
the
remove-deprecated-bufsize
branch
from
6b2f7dc to
eda634b
Compare
Fixed. |
|
Thanks @serhiy-storchaka ! |
This keyword is marked as deprecated since 3.6 and for removal in 3.8.
It already had no effects.
https://bugs.python.org/issue36952