gh-135034: Normalize link targets in tarfile, add os.path.realpath(strict='allow_missing')
#135037
+966
−169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…path(strict='allow_missing')` Addresses CVEs 2024-12718, 2025-4138, 2025-4330, and 2025-4517. Co-authored-by: Petr Viktorin <encukou@gmail.com> Signed-off-by: Łukasz Langa <lukasz@langa.pl>
|
See also #71189. |
AA-Turner
reviewed
Jun 2, 2025
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
encukou
reviewed
Jun 2, 2025
encukou
reviewed
Jun 2, 2025
To align with this, there'd be a |
encukou
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @encukou for commit 5af66c6 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135037%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
This reverts commit fd2013a.
encukou
added
the
🔨 test-with-buildbots
ambv
added a commit
that referenced
this pull request
Jun 3, 2025
…lpath(strict='allow_missing')` (GH-135037) (#135070) Addresses CVEs 2024-12718, 2025-4138, 2025-4330, and 2025-4517. (cherry picked from commit 3612d8f) (cherry picked from commit c358142) (cherry picked from commit 371b4ea) Co-authored-by: Łukasz Langa <lukasz@langa.pl> Signed-off-by: Łukasz Langa <lukasz@langa.pl> Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Seth Michael Larson <seth@python.org> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
ambv
added a commit
that referenced
this pull request
Jun 3, 2025
…path(strict='allow_missing')` (GH-135037) (GH-135084) Addresses CVEs 2024-12718, 2025-4138, 2025-4330, and 2025-4517. (cherry picked from commit 3612d8f) Co-authored-by: Łukasz Langa <lukasz@langa.pl> Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Seth Michael Larson <seth@python.org> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
This was referenced Jun 4, 2025
|
This does fix CVE-2025-4435. Sorry for leaving that out of the commit message. (Thanks @stratakis for asking!) |
This was referenced Jun 4, 2025
This was referenced Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses CVEs 2024-12718, 2025-4138, 2025-4330, and 2025-4517.
[edit @encukou]: Also addresses CVE-2025-4435. Sorry for leaving that out of the commit messages.
Co-authored-by: Petr Viktorin encukou@gmail.com
Signed-off-by: Łukasz Langa lukasz@langa.pl
filter="tar"/filter="data") #135034📚 Documentation preview 📚: https://cpython-previews--135037.org.readthedocs.build/