gh-129824: fix data races in subinterpreters under TSAN #135794
+40
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumaraditya303
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit be846e8 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135794%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
|
This also fixes #116909 so more of test_capi tests can be enabled under free-threading TSAN (will do in follow up). |
colesbury
reviewed
Jul 1, 2025
| @@ -1359,6 +1358,19 @@ _PyType_LookupByVersion(unsigned int version) | |||
| #error "_Py_ATTR_CACHE_UNUSED must be bigger than max" | |||
| #endif | |||
|
|
|||
| static inline unsigned int | |||
| get_next_global_version_tag(void) | |||
There was a problem hiding this comment.
Call this something like "next_global_version_tag(void)" instead of "get_next_global_version_tag".
"get_" makes it sound like a function that retrieves the next version tag without modifying it.
| do { | ||
| old = _Py_atomic_load_uint_relaxed(&_PyRuntime.types.next_version_tag); | ||
| if (old >= _Py_MAX_GLOBAL_TYPE_VERSION_TAG) { | ||
| return (unsigned int)-1; |
There was a problem hiding this comment.
Use 0 for an invalid version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the data races in typeobject.c in subinterpreters under free-threading. The type flags are only modified in the main interpreter as all static types are first initialized in main interpreter. With the fix the test_interpreter_pool tests have no data races in typeobject.c under TSAN (there are still some unrelated data races in module exec like posix and struct).