[3.7] bpo-38374: Remove weakref.ReferenceError from docs (GH-18452) #18455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reflecting changes to the code, removed weakref.ReferenceError from weakref.rst and exceptions.rst. Issue submitter provided evidence that the `weakref.ReferenceError` alias for `ReferenceError` was removed from the code in 2007. Working with @gvanrossum at PyCascades CPython sprint we looked at the code and confirmed that `weakref.ReferenceError` was no longer in `weakref.py`. Based on that analysis I removed references `weakref.ReferenceError` from the two documents where it was still being referenced: `weakref.rst` and `exceptions.rst`. https://bugs.python.org/issue38374 (cherry picked from commit 4eb9f43) Co-authored-by: Roger Hurwitz <rogerhurwitz@gmail.com>
gvanrossum
approved these changes
Feb 11, 2020
|
@rogerhurwitz: Status check is done, and it's a success ✅ . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reflecting changes to the code, removed weakref.ReferenceError from weakref.rst and exceptions.rst.
Issue submitter provided evidence that the
weakref.ReferenceErroralias forReferenceErrorwas removed from the code in 2007. Working with @gvanrossum at PyCascades CPython sprint we looked at the code and confirmed thatweakref.ReferenceErrorwas no longer inweakref.py.Based on that analysis I removed references
weakref.ReferenceErrorfrom the two documents where it was still being referenced:weakref.rstandexceptions.rst.https://bugs.python.org/issue38374
(cherry picked from commit 4eb9f43)
Co-authored-by: Roger Hurwitz rogerhurwitz@gmail.com
https://bugs.python.org/issue38374
Automerge-Triggered-By: @gvanrossum