Skip to content

README: Add link to LICENSE #21565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2020
Merged

README: Add link to LICENSE #21565

merged 1 commit into from
Aug 24, 2020

Conversation

wbnns
Copy link
Contributor

@wbnns wbnns commented Jul 20, 2020

Hi there! Since this is a trivial change, I've titled this without an issue number. This adds a hyperlink to the LICENSE in README.rst, so users don't have to scroll around and can easily navigate to it.

Automerge-Triggered-By: @csabella

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@wbnns

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Copy link
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change. LGTM

@wbnns
Copy link
Contributor Author

wbnns commented Jul 21, 2020

@nanjekyejoannah @eamanu Thanks for reviewing!

Copy link
Contributor

@nanjekyejoannah nanjekyejoannah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why one of the tests never runs

@csabella
Copy link
Contributor

Closing and reopening to retrigger tests.

@wbnns
Copy link
Contributor Author

wbnns commented Aug 24, 2020

@csabella Thanks! :)

@nanjekyejoannah nanjekyejoannah merged commit 3112aab into python:master Aug 24, 2020
Copy link
Contributor

@nanjekyejoannah nanjekyejoannah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wbnns for your contribution.

xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants