Skip to content

[doc] Do not encourage using a base class name in a derived class in FAQ #22177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 21, 2020
Merged

[doc] Do not encourage using a base class name in a derived class in FAQ #22177

merged 2 commits into from
Oct 21, 2020

Conversation

andresdelfino
Copy link
Contributor

Also, referring to the base class (even with super) is irrelevant to the actual question, so omit that.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Sep 9, 2020
@andresdelfino andresdelfino changed the title [doc] Do not promote using a base class name in a derived class [doc] Do not promote using a base class name in a derived class in FAQ Sep 9, 2020
@andresdelfino andresdelfino changed the title [doc] Do not promote using a base class name in a derived class in FAQ [doc] Do not encourage using a base class name in a derived class in FAQ Sep 12, 2020
@andresdelfino andresdelfino mentioned this pull request Sep 18, 2020
Merged
akuchling
akuchling approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@akuchling akuchling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good simplification of the answer.

@methane methane merged commit 4642ccd into python:master Oct 21, 2020
@miss-islington
Copy link
Contributor

Thanks @andresdelfino for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-22844 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 21, 2020
@andresdelfino @miss-islington
Doc: Do not encourage using a base class name in a derived class (pyt…
0fd0dfb 
…honGH-22177)

(cherry picked from commit 4642ccd)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
methane pushed a commit that referenced this pull request Oct 21, 2020
@miss-islington @andresdelfino
Doc: Do not encourage using a base class name in a derived class (GH-…
f72101b 
…22177)

(cherry picked from commit 4642ccd)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
@andresdelfino andresdelfino deleted the do_not_mention_base_class_name branch October 21, 2020 12:12
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@andresdelfino @adorilson
Doc: Do not encourage using a base class name in a derived class (pyt…
c8d38ff 
…honGH-22177)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akuchling akuchling akuchling approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@andresdelfino @miss-islington @bedevere-bot @akuchling @methane @the-knights-who-say-ni