-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
bpo-42318: Fix support of non-BMP characters in Tkinter on macOS #23281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-42318: Fix support of non-BMP characters in Tkinter on macOS #23281
Conversation
a7166d4
to
6290d11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good to me.
I've tested the PR with the copy of Tk 8.6.10 that I reported the issue for, and with this patch the problem is gone. I also get correct syntax colouring in edit windows.
return NULL; | ||
} | ||
Py_UCS4 ch; | ||
for (j = i; i < len; i++, u[j++] = ch) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to reread this loop a couple of times before I understood how the contents of "u" is updated. My C is getting a bit rusty ;-)
The code looks fine though.
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
Sorry @serhiy-storchaka, I had trouble checking out the |
pythonGH-23281). (cherry picked from commit a26215d) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
GH-23784 is a backport of this pull request to the 3.9 branch. |
pythonGH-23281). (pythonGH-23784) (cherry picked from commit a26215d) (cherry picked from commit 28bf6ab) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
pythonGH-23281). (pythonGH-23784) (pythonGH-23787) (cherry picked from commit a26215d) (cherry picked from commit 28bf6ab)
pythonGH-23281). (pythonGH-23784) (pythonGH-23787) (cherry picked from commit a26215d) (cherry picked from commit 28bf6ab)
https://bugs.python.org/issue42318