Skip to content

bpo-17792: more accurate error message for UnboundLocalError #24976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 2, 2021
Merged

bpo-17792: more accurate error message for UnboundLocalError #24976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2229cff
bpo-17792: more accurate error message for UnboundLocalError
iritkatriel Mar 22, 2021
7826eaf
📜🤖 Added by blurb_it.
blurb-it[bot] Mar 22, 2021
d0c3650
update per review discussion. Changed UNBOUNDFREE_ERROR_MSG as well
iritkatriel May 31, 2021
658cab1
update news file to add the free vars change as
iritkatriel May 31, 2021
86ace25
added back 'in enclosing scope' for free var
iritkatriel May 31, 2021
1a146a4
accessed --> cannot access
iritkatriel Jun 1, 2021
ea9857c
accessed --> cannot access
iritkatriel Jun 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core and Builtins/2021-03-22-17-50-30.bpo-17792._zssjS.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
More accurate error messages for access of unbound locals or free vars.
6 changes: 3 additions & 3 deletions Python/ceval.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,10 +101,10 @@ static int get_exception_handler(PyCodeObject *, int, int*, int*, int*);
#define NAME_ERROR_MSG \
"name '%.200s' is not defined"
#define UNBOUNDLOCAL_ERROR_MSG \
"local variable '%.200s' referenced before assignment"
"cannot access local variable '%s' where it is not associated with a value"
#define UNBOUNDFREE_ERROR_MSG \
"free variable '%.200s' referenced before assignment" \
" in enclosing scope"
"cannot access free variable '%s' where it is not associated with a" \
" value in enclosing scope"

/* Dynamic execution profile */
#ifdef DYNAMIC_EXECUTION_PROFILE
Expand Down