Skip to content

bpo-43938: improve dataclasses.FrozenInstanceError documentation #25603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2021
Merged

bpo-43938: improve dataclasses.FrozenInstanceError documentation #25603

merged 1 commit into from
Apr 26, 2021

Conversation

Llandy3d
Copy link
Contributor

@Llandy3d Llandy3d commented Apr 25, 2021 •
edited by bedevere-bot
Loading

Update documentation to reflect that dataclasses.FrozenInstanceError is derived by AttributeError.

https://bugs.python.org/issue43938

https://bugs.python.org/issue43938

@Llandy3d Llandy3d requested a review from ericvsmith as a code owner April 25, 2021 20:51
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@Llandy3d

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

ericvsmith
ericvsmith reviewed Apr 25, 2021
View reviewed changes
Copy link
Member

@ericvsmith ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks. After you sign the CLA I'll merge it.

@ericvsmith ericvsmith merged commit 8a307e4 into python:master Apr 26, 2021
@miss-islington
Copy link
Contributor

Thanks @Llandy3d for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 26, 2021
@Llandy3d @miss-islington
bpo-43938: improve dataclasses.FrozenInstanceError documentation (pyt…
87e9cbe 
…honGH-25603)

(cherry picked from commit 8a307e4)

Co-authored-by: Llandy Riveron Del Risco <llandy3d@gmail.com>
@bedevere-bot
Copy link

GH-25635 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Apr 26, 2021
@bedevere-bot
Copy link

GH-25636 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 26, 2021
@Llandy3d @miss-islington
bpo-43938: improve dataclasses.FrozenInstanceError documentation (pyt…
7d16c4d 
…honGH-25603)

(cherry picked from commit 8a307e4)

Co-authored-by: Llandy Riveron Del Risco <llandy3d@gmail.com>
@Llandy3d Llandy3d deleted the bpo-43938-improve-doc branch April 26, 2021 18:57
ericvsmith pushed a commit that referenced this pull request Apr 26, 2021
@miss-islington @Llandy3d
bpo-43938: improve dataclasses.FrozenInstanceError documentation (GH-…
081bfe4 
…25603) (GH-25636)

(cherry picked from commit 8a307e4)

Co-authored-by: Llandy Riveron Del Risco <llandy3d@gmail.com>

Co-authored-by: Llandy Riveron Del Risco <llandy3d@gmail.com>
ericvsmith pushed a commit that referenced this pull request Apr 26, 2021
@miss-islington @Llandy3d
bpo-43938: improve dataclasses.FrozenInstanceError documentation (GH-…
c9c1dbd 
…25603) (GH-25635)

(cherry picked from commit 8a307e4)

Co-authored-by: Llandy Riveron Del Risco <llandy3d@gmail.com>

Co-authored-by: Llandy Riveron Del Risco <llandy3d@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericvsmith ericvsmith ericvsmith left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Llandy3d @the-knights-who-say-ni @miss-islington @bedevere-bot @ericvsmith