Skip to content

[3.10] bpo-44087: Disallow instantiation of sqlite3.Statement (GH-26567) #26813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[3.10] bpo-44087: Disallow instantiation of sqlite3.Statement (GH-26567) #26813

wants to merge 1 commit into from

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 20, 2021 •
edited by bedevere-bot
Loading

(cherry picked from commit 7d0a47e)

Co-authored-by: Erlend Egeberg Aasland erlend.aasland@innova.no

https://bugs.python.org/issue44087

@miss-islington
bpo-44087: Disallow instantiation of sqlite3.Statement (pythonGH-26567)
8756d86 
(cherry picked from commit 7d0a47e)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@miss-islington
Copy link
Contributor Author

@erlend-aasland and @pablogsal: Status check is done, and it's a success ✅ .

@bedevere-bot bedevere-bot mentioned this pull request Jun 20, 2021
Merged
@pablogsal
Copy link
Member

@erlend-aasland Can you please remade this PR to add the missing test functions?

@pablogsal pablogsal closed this Jun 20, 2021
@miss-islington miss-islington deleted the backport-7d0a47e-3.10 branch June 20, 2021 19:46
@miss-islington
Copy link
Contributor Author

@erlend-aasland and @pablogsal: Status check is done, and it's a failure ❌ .

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Jun 20, 2021 •
edited
Loading

Can you please remade this PR to add the missing test functions?

Seems like we I somehow decided not to backport this test support function (see #25757 (comment)). I'm rewriting this test to match the existing tests in the 3.10 branch. See #26816.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees
No one assigned
Labels
awaiting merge skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miss-islington @pablogsal @erlend-aasland @the-knights-who-say-ni @bedevere-bot