Skip to content

[3.7] bpo-33706: Fix pymain_parse_cmdline_impl() (GH-7283) #7284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2018

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 31, 2018

Fix a crash in Python initialization when parsing the command line
options.

Fix memcpy() size parameter: previously, we read one wchar_t after
the end of _PyOS_optarg. Moreover, don't copy the trailingg NUL
character: we write it manually anyway.

Thanks Christoph Gohlke for the bug report and the fix!
(cherry picked from commit 58d1683)

Co-authored-by: Victor Stinner vstinner@redhat.com

https://bugs.python.org/issue33706

Fix a crash in Python initialization when parsing the command line
options.

Fix memcpy() size parameter: previously, we read one wchar_t after
the end of _PyOS_optarg. Moreover, don't copy the trailingg NUL
character: we write it manually anyway.

Thanks Christoph Gohlke for the bug report and the fix!
(cherry picked from commit 58d1683)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington
Copy link
Contributor Author

@vstinner: Backport status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit c6de46e into python:3.7 May 31, 2018
@miss-islington
Copy link
Contributor Author

Thanks!

@miss-islington miss-islington deleted the backport-58d1683-3.7 branch May 31, 2018 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants