Starter Task 1: Ensuring TQDM Progress Bar Always Enabled #1575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D75814260 |
ArjunR2404
added a commit
to ArjunR2404/captum
that referenced
this pull request
Jun 4, 2025
Summary: My task was to remove the redundant progress bar code now that tqdm is a dependency. The problem was that since tqdm is now a dependency, we don't need to make checks for whether or not tqdm is being used, and thus we can remove the simple progress print code in the progress function (as well as the import error try-except code at the very top of the file). I also removed the SimpleProgress class definition, as well as the use_tqdm parameter in the progress function. Since we are no longer using the SimpleProgress object anywhere, I removed it from wherever it was used in the codebase (feature_ablation.py, this will be submitted as another diff related to all changes made to feature_ablation.py). In the test_progress.py, I removed the tests corresponding to SimpleProgress. Reviewed By: cyrjano Differential Revision: D75814260
ArjunR2404
force-pushed
the
export-D75814260
branch
from
156458e to
1f0b152
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75814260 |
ArjunR2404
added a commit
to ArjunR2404/captum
that referenced
this pull request
Jun 4, 2025
Summary: Pull Request resolved: pytorch#1575 My task was to remove the redundant progress bar code now that tqdm is a dependency. The problem was that since tqdm is now a dependency, we don't need to make checks for whether or not tqdm is being used, and thus we can remove the simple progress print code in the progress function (as well as the import error try-except code at the very top of the file). I also removed the SimpleProgress class definition, as well as the use_tqdm parameter in the progress function. Since we are no longer using the SimpleProgress object anywhere, I removed it from wherever it was used in the codebase (feature_ablation.py, this will be submitted as another diff related to all changes made to feature_ablation.py). In the test_progress.py, I removed the tests corresponding to SimpleProgress. Reviewed By: cyrjano Differential Revision: D75814260
ArjunR2404
force-pushed
the
export-D75814260
branch
from
1f0b152 to
0ad3b55
Compare
ArjunR2404
added a commit
to ArjunR2404/captum
that referenced
this pull request
Jun 4, 2025
Summary: My task was to remove the redundant progress bar code now that tqdm is a dependency. The problem was that since tqdm is now a dependency, we don't need to make checks for whether or not tqdm is being used, and thus we can remove the simple progress print code in the progress function (as well as the import error try-except code at the very top of the file). I also removed the SimpleProgress class definition, as well as the use_tqdm parameter in the progress function. Since we are no longer using the SimpleProgress object anywhere, I removed it from wherever it was used in the codebase (feature_ablation.py, this will be submitted as another diff related to all changes made to feature_ablation.py). In the test_progress.py, I removed the tests corresponding to SimpleProgress. Reviewed By: cyrjano Differential Revision: D75814260
ArjunR2404
force-pushed
the
export-D75814260
branch
from
0ad3b55 to
291b9a8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75814260 |
ArjunR2404
added a commit
to ArjunR2404/captum
that referenced
this pull request
Jun 4, 2025
Summary: Pull Request resolved: pytorch#1575 My task was to remove the redundant progress bar code now that tqdm is a dependency. The problem was that since tqdm is now a dependency, we don't need to make checks for whether or not tqdm is being used, and thus we can remove the simple progress print code in the progress function (as well as the import error try-except code at the very top of the file). I also removed the SimpleProgress class definition, as well as the use_tqdm parameter in the progress function. Since we are no longer using the SimpleProgress object anywhere, I removed it from wherever it was used in the codebase (feature_ablation.py, this will be submitted as another diff related to all changes made to feature_ablation.py). In the test_progress.py, I removed the tests corresponding to SimpleProgress. Reviewed By: cyrjano Differential Revision: D75814260
ArjunR2404
force-pushed
the
export-D75814260
branch
from
291b9a8 to
e602f5d
Compare
ArjunR2404
added a commit
to ArjunR2404/captum
that referenced
this pull request
Jun 4, 2025
Summary: My task was to remove the redundant progress bar code now that tqdm is a dependency. The problem was that since tqdm is now a dependency, we don't need to make checks for whether or not tqdm is being used, and thus we can remove the simple progress print code in the progress function (as well as the import error try-except code at the very top of the file). I also removed the SimpleProgress class definition, as well as the use_tqdm parameter in the progress function. Since we are no longer using the SimpleProgress object anywhere, I removed it from wherever it was used in the codebase (feature_ablation.py, this will be submitted as another diff related to all changes made to feature_ablation.py). In the test_progress.py, I removed the tests corresponding to SimpleProgress. Reviewed By: cyrjano Differential Revision: D75814260
ArjunR2404
force-pushed
the
export-D75814260
branch
from
e602f5d to
db527d5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75814260 |
ArjunR2404
added a commit
to ArjunR2404/captum
that referenced
this pull request
Jun 4, 2025
Summary: Pull Request resolved: pytorch#1575 My task was to remove the redundant progress bar code now that tqdm is a dependency. The problem was that since tqdm is now a dependency, we don't need to make checks for whether or not tqdm is being used, and thus we can remove the simple progress print code in the progress function (as well as the import error try-except code at the very top of the file). I also removed the SimpleProgress class definition, as well as the use_tqdm parameter in the progress function. Since we are no longer using the SimpleProgress object anywhere, I removed it from wherever it was used in the codebase (feature_ablation.py, this will be submitted as another diff related to all changes made to feature_ablation.py). In the test_progress.py, I removed the tests corresponding to SimpleProgress. Reviewed By: cyrjano Differential Revision: D75814260
ArjunR2404
force-pushed
the
export-D75814260
branch
from
db527d5 to
c89789d
Compare
ArjunR2404
added a commit
to ArjunR2404/captum
that referenced
this pull request
Jun 5, 2025
Summary: My task was to remove the redundant progress bar code now that tqdm is a dependency. The problem was that since tqdm is now a dependency, we don't need to make checks for whether or not tqdm is being used, and thus we can remove the simple progress print code in the progress function (as well as the import error try-except code at the very top of the file). I also removed the SimpleProgress class definition, as well as the use_tqdm parameter in the progress function. Since we are no longer using the SimpleProgress object anywhere, I removed it from wherever it was used in the codebase (feature_ablation.py). In the test_progress.py, I removed the tests corresponding to SimpleProgress. Reviewed By: cyrjano Differential Revision: D75814260
ArjunR2404
added a commit
to ArjunR2404/captum
that referenced
this pull request
Jun 5, 2025
Summary: Pull Request resolved: pytorch#1575 My task was to remove the redundant progress bar code now that tqdm is a dependency. The problem was that since tqdm is now a dependency, we don't need to make checks for whether or not tqdm is being used, and thus we can remove the simple progress print code in the progress function (as well as the import error try-except code at the very top of the file). I also removed the SimpleProgress class definition, as well as the use_tqdm parameter in the progress function. Since we are no longer using the SimpleProgress object anywhere, I removed it from wherever it was used in the codebase (feature_ablation.py). In the test_progress.py, I removed the tests corresponding to SimpleProgress. Differential Revision: D75814260 Reviewed By: cyrjano
ArjunR2404
added a commit
to ArjunR2404/captum
that referenced
this pull request
Jun 5, 2025
Summary: My task was to remove the redundant progress bar code now that tqdm is a dependency. The problem was that since tqdm is now a dependency, we don't need to make checks for whether or not tqdm is being used, and thus we can remove the simple progress print code in the progress function (as well as the import error try-except code at the very top of the file). I also removed the SimpleProgress class definition, as well as the use_tqdm parameter in the progress function. Since we are no longer using the SimpleProgress object anywhere, I removed it from wherever it was used in the codebase (feature_ablation.py). In the test_progress.py, I removed the tests corresponding to SimpleProgress. Reviewed By: cyrjano Differential Revision: D75814260
ArjunR2404
force-pushed
the
export-D75814260
branch
from
c89789d to
72d6d83
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75814260 |
ArjunR2404
added a commit
to ArjunR2404/captum
that referenced
this pull request
Jun 5, 2025
Summary: My task was to remove the redundant progress bar code now that tqdm is a dependency. The problem was that since tqdm is now a dependency, we don't need to make checks for whether or not tqdm is being used, and thus we can remove the simple progress print code in the progress function (as well as the import error try-except code at the very top of the file). I also removed the SimpleProgress class definition, as well as the use_tqdm parameter in the progress function. Since we are no longer using the SimpleProgress object anywhere, I removed it from wherever it was used in the codebase (feature_ablation.py). In the test_progress.py, I removed the tests corresponding to SimpleProgress. Reviewed By: cyrjano Differential Revision: D75814260
ArjunR2404
force-pushed
the
export-D75814260
branch
from
72d6d83 to
ed6e3d8
Compare
ArjunR2404
added a commit
to ArjunR2404/captum
that referenced
this pull request
Jun 5, 2025
Summary: My task was to remove the redundant progress bar code now that tqdm is a dependency. The problem was that since tqdm is now a dependency, we don't need to make checks for whether or not tqdm is being used, and thus we can remove the simple progress print code in the progress function (as well as the import error try-except code at the very top of the file). I also removed the SimpleProgress class definition, as well as the use_tqdm parameter in the progress function. Since we are no longer using the SimpleProgress object anywhere, I removed it from wherever it was used in the codebase (feature_ablation.py). In the test_progress.py, I removed the tests corresponding to SimpleProgress. Reviewed By: cyrjano Differential Revision: D75814260
|
This pull request was exported from Phabricator. Differential Revision: D75814260 |
ArjunR2404
added a commit
to ArjunR2404/captum
that referenced
this pull request
Jun 5, 2025
Summary: Pull Request resolved: pytorch#1575 My task was to remove the redundant progress bar code now that tqdm is a dependency. The problem was that since tqdm is now a dependency, we don't need to make checks for whether or not tqdm is being used, and thus we can remove the simple progress print code in the progress function (as well as the import error try-except code at the very top of the file). I also removed the SimpleProgress class definition, as well as the use_tqdm parameter in the progress function. Since we are no longer using the SimpleProgress object anywhere, I removed it from wherever it was used in the codebase (feature_ablation.py). In the test_progress.py, I removed the tests corresponding to SimpleProgress. Reviewed By: cyrjano Differential Revision: D75814260
ArjunR2404
force-pushed
the
export-D75814260
branch
from
ed6e3d8 to
34d9e88
Compare
ArjunR2404
added a commit
to ArjunR2404/captum
that referenced
this pull request
Jun 5, 2025
Summary: Pull Request resolved: pytorch#1575 My task was to remove the redundant progress bar code now that tqdm is a dependency. The problem was that since tqdm is now a dependency, we don't need to make checks for whether or not tqdm is being used, and thus we can remove the simple progress print code in the progress function (as well as the import error try-except code at the very top of the file). I also removed the SimpleProgress class definition, as well as the use_tqdm parameter in the progress function. Since we are no longer using the SimpleProgress object anywhere, I removed it from wherever it was used in the codebase (feature_ablation.py). In the test_progress.py, I removed the tests corresponding to SimpleProgress. Differential Revision: D75814260 Reviewed By: cyrjano
ArjunR2404
added a commit
to ArjunR2404/captum
that referenced
this pull request
Jun 5, 2025
Summary: My task was to remove the redundant progress bar code now that tqdm is a dependency. The problem was that since tqdm is now a dependency, we don't need to make checks for whether or not tqdm is being used, and thus we can remove the simple progress print code in the progress function (as well as the import error try-except code at the very top of the file). I also removed the SimpleProgress class definition, as well as the use_tqdm parameter in the progress function. Since we are no longer using the SimpleProgress object anywhere, I removed it from wherever it was used in the codebase (feature_ablation.py). In the test_progress.py, I removed the tests corresponding to SimpleProgress. Reviewed By: cyrjano Differential Revision: D75814260
ArjunR2404
added a commit
to ArjunR2404/captum
that referenced
this pull request
Jun 5, 2025
Summary: My task was to remove the redundant progress bar code now that tqdm is a dependency. The problem was that since tqdm is now a dependency, we don't need to make checks for whether or not tqdm is being used, and thus we can remove the simple progress print code in the progress function (as well as the import error try-except code at the very top of the file). I also removed the SimpleProgress class definition, as well as the use_tqdm parameter in the progress function. Since we are no longer using the SimpleProgress object anywhere, I removed it from wherever it was used in the codebase (feature_ablation.py). In the test_progress.py, I removed the tests corresponding to SimpleProgress. Reviewed By: cyrjano Differential Revision: D75814260
ArjunR2404
force-pushed
the
export-D75814260
branch
from
34d9e88 to
144a63c
Compare
Summary: Pull Request resolved: pytorch#1575 My task was to remove the redundant progress bar code now that tqdm is a dependency. The problem was that since tqdm is now a dependency, we don't need to make checks for whether or not tqdm is being used, and thus we can remove the simple progress print code in the progress function (as well as the import error try-except code at the very top of the file). I also removed the SimpleProgress class definition, as well as the use_tqdm parameter in the progress function. Since we are no longer using the SimpleProgress object anywhere, I removed it from wherever it was used in the codebase (feature_ablation.py). In the test_progress.py, I removed the tests corresponding to SimpleProgress. Reviewed By: cyrjano Differential Revision: D75814260
ArjunR2404
added a commit
to ArjunR2404/captum
that referenced
this pull request
Jun 5, 2025
Summary: Pull Request resolved: pytorch#1575 My task was to remove the redundant progress bar code now that tqdm is a dependency. The problem was that since tqdm is now a dependency, we don't need to make checks for whether or not tqdm is being used, and thus we can remove the simple progress print code in the progress function (as well as the import error try-except code at the very top of the file). I also removed the SimpleProgress class definition, as well as the use_tqdm parameter in the progress function. Since we are no longer using the SimpleProgress object anywhere, I removed it from wherever it was used in the codebase (feature_ablation.py). In the test_progress.py, I removed the tests corresponding to SimpleProgress. Differential Revision: D75814260 Reviewed By: cyrjano
|
This pull request was exported from Phabricator. Differential Revision: D75814260 |
ArjunR2404
force-pushed
the
export-D75814260
branch
from
144a63c to
40794ad
Compare
|
This pull request has been merged in 0ea32dd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: My task was to remove the redundant progress bar code now that tqdm is a dependency. The problem was that since tqdm is now a dependency, we don't need to make checks for whether or not tqdm is being used, and thus we can remove the simple progress print code in the progress function (as well as the import error try-except code at the very top of the file). I also removed the SimpleProgress class definition, as well as the use_tqdm parameter in the progress function. Since we are no longer using the SimpleProgress object anywhere, I removed it from wherever it was used in the codebase (feature_ablation.py, this will be submitted as another diff related to all changes made to feature_ablation.py). In the test_progress.py, I removed the tests corresponding to SimpleProgress.
Reviewed By: cyrjano
Differential Revision: D75814260