-
-
Notifications
You must be signed in to change notification settings - Fork 650
Add _rank_not_in_group
to idist
#3339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add _rank_not_in_group
to idist
#3339
Conversation
Thanks for the PR @sadra-barikbin ! |
ignite/distributed/utils.py
Outdated
@@ -16,6 +16,9 @@ | |||
) | |||
from ignite.utils import setup_logger | |||
|
|||
if has_hvd_support: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove this as it was for typing only, right?
@vfdev-5 , is XLA's def _do_new_group(self, ranks: List[int], **kwargs: Any) -> Any:
return [ranks] # Shouldn't it return `list(ranks)` ? |
On xla |
Failing test:
|
We have this method coded incorrectly: def _do_new_group(self, ranks: List[int], **kwargs: Any) -> Any:
return hvd.ProcessSet(ranks) it should be def _do_new_group(self, ranks: List[int], **kwargs: Any) -> Any:
return hvd.add_process_set(ranks) and we need to set I'll commit some updates to this PR. |
6e6c0cc
to
9971932
Compare
9971932
to
947ef84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failures seems not to be related to the PR's feature.
Let's fix them later.
Hi there!
To add
_rank_not_in_group
toidist.utils
.