Skip to content

adds argument name for device in test_mean_squared_error #3335 #3351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

BanzaiTokyo
Copy link
Contributor

missing argument name for device when instantiating MeanSquaredError

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this @BanzaiTokyo !

@BanzaiTokyo BanzaiTokyo requested a review from vfdev-5 March 25, 2025 21:50
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vfdev-5 vfdev-5 enabled auto-merge (squash) March 25, 2025 21:52
@vfdev-5 vfdev-5 merged commit ef8d912 into pytorch:master Mar 25, 2025
14 checks passed
@BanzaiTokyo BanzaiTokyo deleted the test_mean_squared_error_missing_device branch March 26, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants