[ROCm] add 4.1 to nightly builds #54635
Conversation
💊 CI failures summary and remediationsAs of commit 8a5793e (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
jeffdaily
added
actionable
module: rocm
Codecov Report
@@ Coverage Diff @@
## master #54635 +/- ##
==========================================
- Coverage 77.46% 77.46% -0.01%
==========================================
Files 1893 1893
Lines 185939 185939
==========================================
- Hits 144039 144029 -10
- Misses 41900 41910 +10 |
ailzhang
added
the
triaged
|
@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
good question. what's the policy here? should we keep 2 minor version for each major? (and when do we remove rocm3?) |
We would like to keep N, N-1, and N-2 versions available to users. This is in line with CI image policy, and aligns in general with the N-2 expectation we've discussed otherwise. This would mean today 4.1, 4.0.1, and 3.10. As requested by @seemethere when we had 4.0 and 4.0.1 releases, patch releases replace the minor release they are replacing. |
|
I agree with idea of keeping 3 most recent versions, but considering that first RoCM release was made against 4.0.1 (and there there are no torchvision for 3.10), we should keep building nightlies only for 4.0.1 and 3.10 |
|
@walterddr merged this pull request in 8cf97cb. |
Depends on pytorch/builder#685.