Skip to content

[MPS] Improve the performance of torch.linear() #91114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[MPS] Improve the performance of torch.linear() #91114

wants to merge 2 commits into from

Conversation

razarmehr
Copy link
Collaborator

@razarmehr razarmehr commented Dec 19, 2022 •
edited by pytorch-bot bot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 19, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91114

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Failures

As of commit 23553a2:

FLAKY - The following jobs failed but were likely due to flakiness present on master:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Dec 19, 2022
@razarmehr razarmehr changed the title Improve the performance of torch.linear() [MPS] Improve the performance of torch.linear() Dec 19, 2022
@razarmehr razarmehr added module: mps Related to Apple Metal Performance Shaders framework and removed module: mps Related to Apple Metal Performance Shaders framework labels Dec 19, 2022
@razarmehr razarmehr requested a review from malfet December 21, 2022 00:21
@ngimel ngimel added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Dec 21, 2022
DenisVieriu97
DenisVieriu97 approved these changes Dec 21, 2022
View reviewed changes
Copy link
Collaborator

@DenisVieriu97 DenisVieriu97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@yrik
Copy link

yrik commented Dec 27, 2022

Looking forward for this one!

@razarmehr
Copy link
Collaborator Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@razarmehr @pytorchmergebot
Improve the performance of torch.linear() (#148)
35bdb0b 
* Improve the performance of torch.linear()

* Clean up redundant headers and namespaces from Linear.mm
@pytorchmergebot
Copy link
Collaborator

Successfully rebased MPS_linear_optimize onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout MPS_linear_optimize && git pull --rebase)

malfet
malfet approved these changes Jan 4, 2023
View reviewed changes
@github-actions github-actions bot added ciflow/inductor module: cpu CPU specific problem (e.g., perf, algorithm) module: inductor labels Jan 4, 2023
@razarmehr razarmehr removed the request for review from zou3519 January 4, 2023 18:32
@razarmehr
Copy link
Collaborator Author

razarmehr commented Jan 4, 2023 •
edited
Loading

Thanks @malfet . I addressed the comments.

@razarmehr razarmehr force-pushed the MPS_linear_optimize branch from e031a0e to 23553a2 Compare January 4, 2023 18:39
@razarmehr razarmehr requested a review from malfet January 4, 2023 18:43
@razarmehr
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 4, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

kulinseth
kulinseth reviewed Jan 4, 2023
View reviewed changes
kulinseth
kulinseth approved these changes Jan 4, 2023
View reviewed changes
Copy link
Collaborator

@kulinseth kulinseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks fine, please add the comment with Github issue.

@razarmehr razarmehr mentioned this pull request Jan 4, 2023
Open
@razarmehr
Copy link
Collaborator Author

Created the issue #91737 to track the optimizations for torch.linear().

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 additional jobs have failed, first few of them are: trunk ,trunk / linux-focal-rocm5.3-py3.8 / test (default, 1, 2, linux.rocm.gpu)

Details for Dev Infra team Raised by workflow job

@razarmehr
Copy link
Collaborator Author

@pytorchbot merge -f "MPS tests are green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@Birch-san Birch-san mentioned this pull request Jan 6, 2023
Open
@malfet malfet mentioned this pull request Jan 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulinseth kulinseth kulinseth approved these changes

@malfet malfet malfet approved these changes

@DenisVieriu97 DenisVieriu97 DenisVieriu97 approved these changes

@albanD albanD Awaiting requested review from albanD

Assignees
No one assigned
Labels
ciflow/inductor ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request Merged module: cpu CPU specific problem (e.g., perf, algorithm) module: inductor open source release notes: mps Release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@razarmehr @yrik @pytorchmergebot @kulinseth @malfet @DenisVieriu97 @ngimel @pytorchbot