Skip to content

pin jinja2<3.1.* for docs #5674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 24, 2022
Merged

pin jinja2<3.1.* for docs #5674

merged 3 commits into from
Mar 24, 2022

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Mar 24, 2022

Fixes #5673

@pmeier pmeier requested a review from NicolasHug March 24, 2022 15:44
@facebook-github-bot
Copy link

facebook-github-bot commented Mar 24, 2022 •
edited
Loading

💊 CI failures summary and remediations

As of commit c2e27c9 (more details on the Dr. CI page):

1 failure not recognized by patterns:

Job Step Action
CircleCI cmake_linux_gpu Build torchvision C++ distribution and test 🔁 rerun

🚧 3 ongoing upstream failures:

These were probably caused by upstream breakages that are not fixed yet.

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@pmeier
Copy link
Collaborator Author

pmeier commented Mar 24, 2022

Passing workflow: https://app.circleci.com/pipelines/github/pytorch/vision/16043/workflows/62719384-f6aa-4635-a411-75602a4ce414/jobs/1298787

NicolasHug
NicolasHug approved these changes Mar 24, 2022
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamping, thanks @pmeier

@pmeier pmeier merged commit 1af20e8 into pytorch:main Mar 24, 2022
@pmeier pmeier deleted the pin-jinja2 branch March 24, 2022 16:12
@github-actions
Copy link

Hey @pmeier!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@pmeier pmeier added the other if you have no clue or if you will manually handle the PR in the release notes label Mar 24, 2022
@pmeier
Copy link
Collaborator Author

pmeier commented Mar 24, 2022

@NicolasHug could we move dependency issue from secondary to primary label?

@NicolasHug
Copy link
Member

I guess we could leave it in both

facebook-github-bot pushed a commit that referenced this pull request Apr 5, 2022
@jdsgomes @facebook-github-bot
[fbsync] pin jinja2<3.1.* for docs (#5674)
4c41349 
Summary: (Note: this ignores all push blocking failures!)

Reviewed By: datumbox

Differential Revision: D35216773

fbshipit-source-id: c5b41947343c076d320e0229c05f498115fbceb9
@pmeier pmeier mentioned this pull request Apr 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
cla signed dependency issue module: documentation other if you have no clue or if you will manually handle the PR in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jinja2==3.1.0 breaks build workflow
3 participants
@pmeier @facebook-github-bot @NicolasHug