Fix for cygpath windows issue #6513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huydhn
approved these changes
Aug 29, 2022
|
Hey @atalman! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 30, 2022
Reviewed By: NicolasHug Differential Revision: D39131007 fbshipit-source-id: 4ebe2319076b92117786b148d24b8327cf9b0ef4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6496
This forces the path to use windows path rather then path prefixed with cygdrive:
wrong:
correct:
CI Job: https://app.circleci.com/pipelines/github/pytorch/vision/19847/workflows/a3756ade-45cf-4d43-8071-3e52e37080a2/jobs/1609649