-
Notifications
You must be signed in to change notification settings - Fork 187
New nzchar_linter #2275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New nzchar_linter #2275
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2275 +/- ##
=======================================
Coverage 99.45% 99.45%
=======================================
Files 116 117 +1
Lines 5286 5341 +55
=======================================
+ Hits 5257 5312 +55
Misses 29 29 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing metadata tests.
@MichaelChirico This should be ready for a merge after the merge conflict is resolved. |
Part of #884
Some notes:
if (x == "")
optionalNA_character_
. I really find the mismatch of defaults in R confusing here. We could consider a weaker version of this linter that only lintsnchar(x, keepNA = FALSE)