Skip to content

New nzchar_linter #2275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 18, 2023
Merged

New nzchar_linter #2275

merged 9 commits into from
Nov 18, 2023

Conversation

MichaelChirico
Copy link
Collaborator

Part of #884

Some notes:

  • We could easily make the behavior we chose to skip linting if (x == "") optional
  • This linter may be somewhat controversial because of the difference in handling NA_character_. I really find the mismatch of defaults in R confusing here. We could consider a weaker version of this linter that only lints nchar(x, keepNA = FALSE)
  • No lints on {lintr}

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7970260) 99.45% compared to head (fdf83e4) 99.45%.

❗ Current head fdf83e4 differs from pull request most recent head dc1e515. Consider uploading reports for the commit dc1e515 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2275   +/-   ##
=======================================
  Coverage   99.45%   99.45%           
=======================================
  Files         116      117    +1     
  Lines        5286     5341   +55     
=======================================
+ Hits         5257     5312   +55     
  Misses         29       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@AshesITR AshesITR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing metadata tests.

AshesITR
AshesITR previously approved these changes Nov 18, 2023
@IndrajeetPatil
Copy link
Collaborator

@MichaelChirico This should be ready for a merge after the merge conflict is resolved.

@IndrajeetPatil IndrajeetPatil merged commit 1d84cae into main Nov 18, 2023
@IndrajeetPatil IndrajeetPatil deleted the require_nzchar branch November 18, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants