Skip to content

move test outside loop in backport_linter factory #2339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

MichaelChirico
Copy link
Collaborator

Related: #2338. This is not the primary source of inefficiency but should nevertheless remove some overhead.

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3fd1bd6) 99.40% compared to head (d523cb1) 99.40%.

❗ Current head d523cb1 differs from pull request most recent head 81be15e. Consider uploading reports for the commit 81be15e to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2339   +/-   ##
=======================================
  Coverage   99.40%   99.40%           
=======================================
  Files         123      123           
  Lines        5585     5585           
=======================================
  Hits         5552     5552           
  Misses         33       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IndrajeetPatil IndrajeetPatil merged commit 1c36e0d into main Nov 23, 2023
@IndrajeetPatil IndrajeetPatil deleted the backport-performance branch November 23, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants