Skip to content

Error earlier for missing lint_message #2541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 1, 2024
Merged

Error earlier for missing lint_message #2541

merged 2 commits into from
Apr 1, 2024

Conversation

MichaelChirico
Copy link
Collaborator

Nice to have this error early, currently lazy evaluation hides it until lrun time.

@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 98.14%. Comparing base (713fb0b) to head (1c14890).

❗ Current head 1c14890 differs from pull request most recent head 1d73d08. Consider uploading reports for the commit 1d73d08 to get more accurate results

Files Patch % Lines
R/make_linter_from_xpath.R 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2541      +/-   ##
==========================================
- Coverage   98.16%   98.14%   -0.02%     
==========================================
  Files         125      125              
  Lines        5715     5717       +2     
==========================================
+ Hits         5610     5611       +1     
- Misses        105      106       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelChirico MichaelChirico merged commit 72e57b8 into main Apr 1, 2024
@MichaelChirico MichaelChirico deleted the missing-msg branch April 1, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants