Skip to content

Sync with reactjs.org @ 5fdb6a2e #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 19, 2019
Merged

Sync with reactjs.org @ 5fdb6a2e #14

merged 6 commits into from
Feb 19, 2019

Conversation

reactjs-translation-bot
Copy link
Contributor

@reactjs-translation-bot reactjs-translation-bot commented Feb 18, 2019

This PR was automatically generated.

Merge changes from reactjs.org at 5fdb6a2

The following files have conflicts and may need new translations:

  • README.md

DO NOT SQUASH MERGE THIS PULL REQUEST!

Doing so will "erase" the commits from master and cause them to show up as conflicts the next time we merge.

@sorousht
Copy link
Collaborator

The conflict has been resolved in a new PR #15

@sorousht sorousht closed this Feb 18, 2019
@sJJdGG
Copy link
Member

sJJdGG commented Feb 19, 2019

@sorousht I don't think it's the correct way to resolve upstream merge conflicts.
All merge requests opened by translation bot has to be merged eventually instead of closing and opening a new pr (#15 in this matter) to do the same thing
You should push your commits to the same branch which has a PR opened by the bot. e.g. reactjs/es.react.dev#157
It's necessary because of keeping the commit history I think.
Also as indicated by the bot squashing is prohibited for the same reason.
Reopening for keeping the conversation going on this matter.
@tesseralis What do you think?

@tesseralis
Copy link
Member

@sJJdGG is right. You should just merge the conflicts and push in this branch instead of opening up a new PR. I can edit the issue description to make this more clear.

@tesseralis tesseralis requested a review from a team February 19, 2019 04:09
@tesseralis
Copy link
Member

Actually... as long as “master” from reactjs.org gets merged it doesn’t matter if you use this sync branch or make your own. I’d prefer editing this branch directly but it’s up to you!

@sorousht
Copy link
Collaborator

@sJJdGG @tesseralis I've just resolved the conflict and pushed to the sync branch. Is it ok?

@tesseralis
Copy link
Member

Yup!

@tesseralis tesseralis requested a review from sJJdGG February 19, 2019 09:39
@tesseralis tesseralis merged commit fd0c0e6 into master Feb 19, 2019
@delete-merged-branch delete-merged-branch bot deleted the sync-5fdb6a2e branch February 19, 2019 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants